Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the deployment process by integrating Cert-Manager for TLS management, adding monitoring support for PostgreSQL, and updating deployment configurations for improved usability.
- Added a monitoring configuration block to the GKE cluster resource.
- Introduced new environment variables and Stripe configuration in Helm values and deployment templates.
- Updated the deployment script to include a repository update and modified issuer flags.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| infrastructure/gke.tf | Added monitoring_config block, but the value for enable_components may need adjustment. |
| helm/values.yaml | Added Stripe keys and enabled Grafana default dashboards to support monitoring enhancements. |
| helm/templates/webapp/ingress.yaml | Updated Ingress TLS hosts and standardized service name quoting. |
| helm/templates/webapp/deployment.yaml | Added Stripe environment variables; note a typo in the webhook secret key name. |
| helm/templates/security/prod-issuer.yaml | Removed conditional templating for issuer configuration. |
| deploy.sh | Updated Helm deploy script to include repo updates and modified issuer flag for deployment. |
| .github/workflows/deploy.yaml | Updated secret settings and issuer flag, although a configuration inconsistency exists. |
Comments suppressed due to low confidence (2)
infrastructure/gke.tf:21
- The value 'SCHEDULER' may require quoting or wrapping in a list depending on Terraform's expected type for enable_components. Please verify if it should be written as ["SCHEDULER"] or "SCHEDULER".
enable_components = SCHEDULER
deploy.sh:50
- The issuer.enabled flag is set to false in deploy.sh while it is set to true in the GitHub workflow. Ensure that this discrepancy is intentional to avoid deployment inconsistencies.
--set issuer.enabled=false
matined
previously approved these changes
May 18, 2025
matined
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the deployment process, including the integration of Cert-Manager for TLS/SSL management, monitoring improvements with a PostgreSQL exporter, and configuration updates for better usability and functionality. Below is a summary of the most important changes grouped by theme:
Cert-Manager Integration:
.github/workflows/deploy.yaml).letsencrypt-prodIssuer resource for managing TLS certificates (helm/templates/security/prod-issuer.yaml).helm/templates/webapp/ingress.yaml). [1] [2]Monitoring Enhancements:
helm/templates/database/exporter.yaml).infrastructure/gke.tf).Deployment and Configuration Updates:
deploy.sh). [1] [2]helm/values.yaml). [1] [2]Bug Fixes:
NEXT_PUBLIC_APP_URLenvironment variable key in the web app deployment template (helm/templates/webapp/deployment.yaml).